Skip to content

Conversation

@DanielePalaia
Copy link
Contributor

@DanielePalaia DanielePalaia commented May 9, 2023

Summary Of Changes

Previously -amd64 and -arm64 images were created with tags sha-amd64 and sha-arm64.
For our carvel-pipeline to work properly is convinient to have images tagged with version-amd64 and version-arm64 (ex 2.2.0-amd64 and 2.2.0-arm64 when a new release happens).

Also:
type=semver,pattern={{major}}.{{minor}}
type=semver,pattern={{major}},enable=${{ !startsWith(github.ref, 'refs/tags/v0.') }}

seems not necessary as these created tags of type 2.2 and 2

for example https://hub.docker.com/r/rabbitmqoperator/cluster-operator/tags?page=1&name=2.2

I have tested these modifications cloning the repo https://github.com/DanielePalaia/cluster-operator/blob/main/.github/workflows/build-test-publish.yml and using my dockerhub account:
https://hub.docker.com/repository/docker/danielepalaia/cluster-operator/general

Additional Context

Local Testing

Please ensure you run the unit, integration and system tests before approving the PR.

To run the unit and integration tests:

$ make unit-tests integration-tests

You will need to target a k8s cluster and have the operator deployed for running the system tests.

For example, for a Kubernetes context named dev-bunny:

$ kubectx dev-bunny
$ make destroy deploy-dev
# wait for operator to be deployed
$ make system-tests

@DanielePalaia DanielePalaia merged commit cb43b10 into main May 9, 2023
@DanielePalaia DanielePalaia deleted the fix_buildtestpublish_workflow_arm64 branch May 9, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants