Skip to content

Conversation

@coro
Copy link
Contributor

@coro coro commented Aug 24, 2022

Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed

Summary Of Changes

Added dependabot to the list of excluded authors for the sake of generating release notes.

Additional Context

Once I know this is working, I will add this also to the other operators.

Local Testing

Please ensure you run the unit, integration and system tests before approving the PR.

To run the unit and integration tests:

$ make unit-tests integration-tests

You will need to target a k8s cluster and have the operator deployed for running the system tests.

For example, for a Kubernetes context named dev-bunny:

$ kubectx dev-bunny
$ make destroy deploy-dev
# wait for operator to be deployed
$ make system-tests

Copy link
Contributor

@ChunyiLyu ChunyiLyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please do the same for topology operator as well?

@coro
Copy link
Contributor Author

coro commented Aug 24, 2022

Could you please do the same for topology operator as well?

Yep, I'm just going to double check it gives the correct input first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants