Remove RabbitMQ 3.8 support #1111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we bumped the minimum supported RabbitMQ version to v3.9.0 in #1110, we can use the CLI command `rabbitmqctl enable_feature_flag all` introduced in rabbitmq/rabbitmq-server@ce65586.
Since we bumped the minimum supported RabbitMQ version to v3.9.0 in #1110, we can delete the deprecated `cluster_formation.randomized_startup_delay_range` configurations. See rabbitmq/rabbitmq-server#3075. Prior to this commit, the RabbitMQ logs contained the following warning: ``` 2022-08-15 08:18:03.870480+00:00 [warn] <0.130.0> cluster_formation.randomized_startup_delay_range.min and cluster_formation.randomized_startup_delay_range.max are deprecated ```
Follow up of #1110: The new minimum supported version is 3.9.0. Therefore, we should test against that version to make sure the cluster-operator is compatible with the minimum supported version.
coro
approved these changes
Aug 15, 2022
Contributor
coro
left a comment
coro
left a comment
There was a problem hiding this comment.
Love it. Let's make sure to be explicit in our release notes for this cluster operator version then since we're now explicitly relying on behaviour in 3.9 rather than implicitly dropping support for 3.8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we dropped support for RabbitMQ 3.8 in #1110, we can now simplify the cluster-operator:
cluster_formation.randomized_startup_delay_rangeconfigurations such that warning[warn] <0.130.0> cluster_formation.randomized_startup_delay_range.min and cluster_formation.randomized_startup_delay_range.max are deprecatedwon't be output anymore in RabbitMQ logs. See Remove randomized startup delays rabbitmq-server#3075.rabbitmqctl enable_feature_flag allcommand introduced by @mkuratczyk and @michaelklishin in rabbitmq/rabbitmq-server@ce65586.