Update envtest to use latest available 1.22 #1014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to changes in graceful signal handling in testenv, our tests timeout to teardown testenv and cause an afterSuite failure. The workaround is to cancel the context in the manager to avoid waiting for pending requests in the API server. Signed-off-by: Aitor Perez Cedres <[email protected]>
ChunyiLyu
approved these changes
Apr 25, 2022
Contributor
ChunyiLyu
left a comment
ChunyiLyu
left a comment
There was a problem hiding this comment.
Nice! Would you mind doing the same for top operator?
MirahImage
approved these changes
Apr 25, 2022
Member
Author
Sure thing |
Zerpet
added a commit
to rabbitmq/messaging-topology-operator
that referenced
this pull request
Apr 25, 2022
EnvTest changed the signal handling in 1.21, which caused an after suite failure. Check rabbitmq/cluster-operator#1014 for more context on the root cause and investigation. Signed-off-by: Aitor Perez Cedres <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary Of Changes
Due to changes in graceful signal handling in testenv, our tests timeout
to teardown testenv and cause an afterSuite failure. The workaround is
to cancel the context in the manager to avoid waiting for pending
requests in the API server.
Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Additional Context
Check the discussion in kubernetes-sigs/controller-runtime#1571 about the problem.
Local Testing
Changes to integration tests. Unit and system tests are unaffected.