Fix deadlock between publishing and receiving confirms #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Confirms come in asynchronously and are put onto the confirmation channel. This will block until the consumer receives on that channel. If a user is alternating publishing and consuming acknowledgements, an acknowledgement that comes in during a publish will cause a deadlock.
benmoss
force-pushed
the
fix-confirms-deadlock
branch
from
2a100fa to
08f1cc5
Compare
MirahImage
approved these changes
Nov 17, 2021
|
Using different muteness for different owned resources makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Confirms come in asynchronously and are put onto the confirmation channel. This will block until the consumer receives on that channel. If a user is alternating publishing and consuming confirms, a confirm that comes in during a publish will cause a deadlock.
Fixes #10