-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update spec091.go #224
Update spec091.go #224
Conversation
I think there is more strict lint checking in some areas :)
…On Wed, 27 Sept 2023 at 12:23, Luke Bakken ***@***.***> wrote:
@Zerpet <https://github.com/Zerpet> is this file auto-generated? I will
see if I can figure that out.
@pinkfish <https://github.com/pinkfish> we do go lint checking as part of
GitHub actions. How was this formatting missed?
—
Reply to this email directly, view it on GitHub
<#224 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AATOMMMLLES43ZNBHTPLUUTX4R4JNANCNFSM6AAAAAA5J2OYBM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is auto-generated. If you want to make changes, you will have to update spec/gen.go
and gen.sh
script. TBH, the change looks more cosmetic than an actual lint error.
@pinkfish - That's good to know, but I'm interested in specific details:
As @Zerpet said, as far as our current linter is concerned, there is no issue here, so we'll need more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code that generates spec091.go
must be updated, and re-run.
Fix up a go lint error with no space between the // and the text.
I think it is go vet buildtag It is because the no space after a // should be a compiler tag for the +build pieces. |
@pinkfish hmm this is what I get when I run that command:
It seems like
|
Fix up a go lint error with no space between the // and the text.