Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spec091.go #224

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Update spec091.go #224

merged 2 commits into from
Oct 2, 2023

Conversation

pinkfish
Copy link
Contributor

Fix up a go lint error with no space between the // and the text.

@lukebakken lukebakken self-assigned this Sep 27, 2023
@lukebakken lukebakken added this to the 1.9.0 milestone Sep 27, 2023
@lukebakken
Copy link
Contributor

@Zerpet is this file auto-generated? I will see if I can figure that out.

@pinkfish we do go lint checking as part of GitHub actions. How was this formatting missed?

@pinkfish
Copy link
Contributor Author

pinkfish commented Sep 27, 2023 via email

Copy link
Contributor

@Zerpet Zerpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is auto-generated. If you want to make changes, you will have to update spec/gen.go and gen.sh script. TBH, the change looks more cosmetic than an actual lint error.

@lukebakken
Copy link
Contributor

I think there is more strict lint checking in some areas :)

@pinkfish - That's good to know, but I'm interested in specific details:

  • Which linter are you using?
  • How can I run it to see this particular formatting issue being raised as an error?

As @Zerpet said, as far as our current linter is concerned, there is no issue here, so we'll need more information.

Copy link
Contributor

@lukebakken lukebakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code that generates spec091.go must be updated, and re-run.

Fix up a go lint error with no space between the // and the text.
@pinkfish
Copy link
Contributor Author

I think it is go vet buildtag

It is because the no space after a // should be a compiler tag for the +build pieces.

@lukebakken
Copy link
Contributor

@pinkfish hmm this is what I get when I run that command:

C:\Users\lbakken\development\rabbitmq\amqp091-go [main ≡]
> go vet buildtag
package buildtag is not in std (C:\Users\lbakken\scoop\apps\go\current\src\buildtag)

It seems like -buildtag is the correct argument. But, when I run it, no errors are returned:

C:\Users\lbakken\development\rabbitmq\amqp091-go [main ≡]
> go vet -all
C:\Users\lbakken\development\rabbitmq\amqp091-go [main ≡]
> go vet -buildtag

@lukebakken lukebakken merged commit 607b817 into rabbitmq:main Oct 2, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants