Bump versions #219
Merged
Bump versions #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukebakken
force-pushed
the
lukebakken/update-versions
branch
from
f032e8c to
329b4bc
Compare
Gsantomaggio
approved these changes
Sep 12, 2023
Zerpet
reviewed
Sep 12, 2023
There was a problem hiding this comment.
This looks good. I added the aliases oldstable and stable to our setup-go action; those use the last two supported Go versions (following Go support policy).
We seem to have a consistent failure in TestIntegrationTxCommit in Windows 🤔
@lukebakken are you able to reproduce this locally? This is passing for me consistently on MacOS
Edit: feel free to revert my commit if you prefer to keep pinned versions of Go minor versions
|
@Zerpet yes that failure is known and @acogoluegnes is fixing it here: I think I'll downgrade the version of RMQ used for testing for now, but I would like us to test client libs with the latest supported RMQ versions and upcoming betas. |
lukebakken
force-pushed
the
lukebakken/update-versions
branch
from
21d0c14 to
17fda21
Compare
Golang 1.19 is no longer supported. Usa oldstable and stable aliases Since actions/setup-go v3, we can use oldstable and stable aliases to always refer to the two latest supported versions of Go. Signed-off-by: Aitor Perez Cedres <[email protected]>
lukebakken
force-pushed
the
lukebakken/update-versions
branch
from
17fda21 to
0f3be01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Golang 1.19 is no longer supported.