Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for cert-only login without user and password #20

Merged
merged 1 commit into from
Oct 14, 2021

Conversation

mihaitodor
Copy link

@mihaitodor mihaitodor commented Oct 1, 2021

This PR contains the changes proposed in streadway/amqp#121 by
@p-kraszewski together with the changes that @wolf-james requested and some small comment additions for consistency.

Note that I'm not really familiar with this protocol and I haven't looked into setting up a test environment for this setup. People have confirmed that the changes are correct in the original PR, but please let me know if you'd prefer some extra validation and I'll look into it when I'll have some time.

Update: I was able to validate these changes and I documented the steps I followed here: https://github.com/mihaitodor/amqp_tls_go_demo

@Zerpet
Copy link
Contributor

Zerpet commented Oct 4, 2021

This PR makes sense to me. WDYT @michaelklishin @ChunyiLyu ?

@mihaitodor
Copy link
Author

Hey everyone, if possible, could you please let me know if there’s a chance this API addition will be released soon?

@Zerpet Zerpet merged commit 60a96d5 into rabbitmq:main Oct 14, 2021
@Zerpet
Copy link
Contributor

Zerpet commented Oct 14, 2021

I'd like to investigate some of the issues we have regarding dead locks before we produce a new release; those seem important. I won't commit to a date, but in a few weeks, depending on the conclusion of those issues, sounds reasonable to produce a new release.

Now that the PR is merged, you could pin your Go dependency to the commit SHA. Not ideal, but at least you'll be able to use external auth.

@mihaitodor
Copy link
Author

Awesome, thank you very much @Zerpet! Indeed, deadlocks don't sound good. I'll have a look too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants