Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate the QueueInspect function #168

Merged
merged 4 commits into from
Feb 8, 2023
Merged

Deprecate the QueueInspect function #168

merged 4 commits into from
Feb 8, 2023

Conversation

lukebakken
Copy link
Contributor

Fixes #167

#165

@lukebakken lukebakken added this to the 1.6.1 milestone Feb 1, 2023
@lukebakken lukebakken requested a review from Zerpet February 1, 2023 16:12
@lukebakken lukebakken self-assigned this Feb 1, 2023
Zerpet
Zerpet approved these changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@Zerpet Zerpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Zerpet
Copy link
Contributor

Zerpet commented Feb 2, 2023 •
edited
Loading

From semver point of view, is it ok to deprecate a function in a patch release? 🤔

Edit: Actually, according to semver point 7, we have to increment the minor version, if we deprecate this function.

@lukebakken lukebakken modified the milestones: 1.6.1, 1.7.0 Feb 2, 2023
@lukebakken
Copy link
Contributor Author

@Zerpet thanks for checking that.

@Zerpet
Copy link
Contributor

Zerpet commented Feb 8, 2023

Now that 1.6.1 is out, are there any blockers to merge this PR?

@lukebakken
Copy link
Contributor Author

Now that 1.6.1 is out, are there any blockers to merge this PR?

There's no guarantee there won't be a 1.6.2 version. It's fine to leave this PR open until we're certain the next version to ship is 1.7.0.

@lukebakken lukebakken merged commit 444e310 into main Feb 8, 2023
@lukebakken lukebakken deleted the amqp091-go-167 branch February 8, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zerpet Zerpet Zerpet approved these changes

Assignees

@lukebakken lukebakken

Labels
None yet
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

Deprecate QueueInspect
2 participants
@lukebakken @Zerpet