Update Makefile targets related to RabbitMQ #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplified version of 'stop-rabbitmq-server'. There is no need to figure out the container ID, because `docker stop` supports container names. Container name can now be customised. Signed-off-by: Aitor Perez Cedres <[email protected]>
lukebakken
approved these changes
Feb 1, 2023
|
Handy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Simplified version of 'stop-rabbitmq-server'. There is no need to figure
out the container ID, because
docker stopsupports container names.Container name can now be customised.
Edit: did not assign a milestone because this change is for developers of the library