Supply library-defined props with NewConnectionProperties

[slagiewka]

Fixes #152

[slagiewka]

I wasn't too sure about testing this. What would be your expectations for this? A simple check if NewConnectionProperties always returns the fixed set?

[Zerpet]

Thank you for the PR! Yes, I think a simple check to assert the existence of the expected keys and values would suffice. The keys platform and product should not change overtime. The key version is changing between releases, so we could assert that its value is a valid semver string.

[slagiewka]

Thank you for the PR! Yes, I think a simple check to assert the existence of the expected keys and values would suffice. The keys platform and product should not change overtime. The key version is changing between releases, so we could assert that its value is a valid semver string.

I added a test for both. However I'm not too sure about the version string being checked here. Ideally it would be valid whether or not we have something (e.g. NewConnectionProperties) using it and testing it on its own.

[lukebakken]

Thank you for your contribution!

[Zerpet]

Thank you for the PR! Yes, I think a simple check to assert the existence of the expected keys and values would suffice. The keys platform and product should not change overtime. The key version is changing between releases, so we could assert that its value is a valid semver string.

I added a test for both. However I'm not too sure about the version string being checked here. Ideally it would be valid whether or not we have something (e.g. NewConnectionProperties) using it and testing it on its own.

I understand your point, and I think it's a matter of preference. I personally want my tests to be red when/if I do something (very) wrong, like setting the version string to foo. Similarly, I think it's ok to assert on values for product and platform, because these values become part of the contract when the constructor sets them; therefore, if we break this contract, tests should be red.

Thank you for your contribution!