Fix linter warnings #156
Merged
Fix linter warnings #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Unreachable code - Variable names using snake_case instead of CamelCase - Unused parameters - Redundant parenthesis - Shell-bang was not set correctly Any code after `t.Fatalf` is not executed, because this function stops execution. Signed-off-by: Aitor Pérez Cedres <[email protected]>
|
Don't we have a CI action that should fail because of these issues? |
|
We do have the |
|
I've been looking around the linter in I also had a look at staticcheck linter, and it catches a few cosmetic issues (strings should not be capitalized), but it doesn't catch unreachable code. |
lukebakken
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes linter warnings, reported in the Goland IDE. The warnings in
question:
Any code after
t.Fatalfis not executed, because this function stopsexecution.