Add constant for default exchange #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. I'd like to see this moved to a separate set of constants, because the default exchange is not an exchange type, it's the name of a direct exchange. @Zerpet @Gsantomaggio @michaelklishin any other "well known" names for things in RabbitMQ like the default exchange? I'm drawing a blank right now and I blame my cold. |
michaelklishin
requested changes
Dec 5, 2022
There was a problem hiding this comment.
I agree with @lukebakken.
The only standard name I can think of is not particularly creative: DefaultExchange.
marlongerson
force-pushed
the
default-exchange-constant
branch
from
e621fb6 to
4043404
Compare
marlongerson
force-pushed
the
default-exchange-constant
branch
from
4043404 to
0dec4f6
Compare
michaelklishin
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defining a constant for the default exchange is clearer than using an empty string
"".