Update AMQP Spec #110
Merged
Update AMQP Spec #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding missing constant 302 for no-route error. The spec says that `basic.recover` should be async, but this breaks our test `TestIntegrationRecoverNotImplemented()`. RabbitMQ has deprecated this method and it will be removed in a future release. This commit also adds a deprecation notice to `channel.Recover()`. Signed-off-by: Aitor Perez Cedres <[email protected]>
|
I'm assuming this PR should also have the code to fix #107 in it as well? |
lukebakken
reviewed
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding missing constant 302 for no-route error.
The spec says that
basic.recovershould be async, but this breaks ourtest
TestIntegrationRecoverNotImplemented(). RabbitMQ has deprecatedthis method and it will be removed in a future release. This commit also
adds a deprecation notice to
channel.Recover().