Add convenience function to set connection name #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RabbitMQ reads the connection property "connection_name" from the client and displays the value in the Management UI. This is convenient for debugging and locating specific client connections, and correlating a connection to an app. Showed in the examples how to use this function and added an example in Go Docs. Signed-off-by: Aitor Perez Cedres <[email protected]>
|
Reviewing this today! |
lukebakken
approved these changes
Aug 17, 2022
| @@ -66,7 +66,7 @@ type Consumer struct { | |||
| } | |||
|
|
|||
| func SetupCloseHandler(consumer *Consumer) { | |||
| c := make(chan os.Signal) | |||
| c := make(chan os.Signal, 2) | |||
There was a problem hiding this comment.
I'm curious why this change is necessary...???
There was a problem hiding this comment.
go vet was complaining about using unbuffered channels with os.Signal
go vet _examples/simple-consumer/consumer.go
# command-line-arguments
# _examples/simple-consumer/consumer.go:70:2: misuse of unbuffered os.Signal channel as argument to signal.Notify
Happy to remove this and make another PR for govet and any other linter warnings, if you'd prefer.
There was a problem hiding this comment.
Nope! I appreciate the explanation.
There was a problem hiding this comment.
I could have sworn we run something like go vet in CI. I'll check.
There was a problem hiding this comment.
I suspect the golangci-lint tool we use is scanning only the root directory, and missing the _example directories. Likely same story for go vet ./...
lukebakken
deleted the
105-provide-a-friendly-way-to-set-connection-name
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RabbitMQ reads the connection property "connection_name" from the client and displays the value in the Management UI. This is convenient for debugging and locating specific client connections, and correlating a connection to an app.
See #105 for more details.