Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to the RAPT pitch extraction algorithm #30

Closed
jfsantos opened this issue Oct 20, 2015 · 4 comments · Fixed by #32
Closed

Add support to the RAPT pitch extraction algorithm #30

jfsantos opened this issue Oct 20, 2015 · 4 comments · Fixed by #32
Milestone

Comments

@jfsantos
Copy link
Contributor

I would like to use RAPT as the pitch extraction algorithm as in my (limited) experience it has slightly better performance than SWIPE'. Could you describe the required steps to add it? I can implement it myself and send a pull request.

@r9y9
Copy link
Owner

r9y9 commented Oct 23, 2015

I assume you have already found steps to support RAPT :).

Actually, I tried to expose the RAPT interface in SPTK one or two years ago, but I gave up to do that since the code was too complicated, I thought. Pull request is really welcome!

@jfsantos
Copy link
Contributor Author

I still have not managed to wrap it. The code is really weird and dependant on using a linked list instead of an array as input. I might try to tackle this soon, but as I could not waste much time on this I implemented an ugly wrapper which simply pipes data in and out to the SPTK pitch binary.

@r9y9
Copy link
Owner

r9y9 commented Oct 24, 2015

Good news: I refactored the RAPT code a bit and probably was able to warp RAPT with a simple interface which takes input as an array instead of a linked list. I'm going to write a regression test to ensure my fixes don't do anything wrong.

r9y9 added a commit that referenced this issue Oct 24, 2015
A regression test is also added, that passes in my local environment.

ref r9y9/SPTK#12

should fix #30
@r9y9 r9y9 mentioned this issue Oct 24, 2015
3 tasks
@r9y9 r9y9 added this to the 0.1.4 milestone Oct 24, 2015
@jfsantos
Copy link
Contributor Author

This is great! Unfortunately I did not have time to help you review it, but I'm sure you did a great job. I will check this out this week to help test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants