Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chapter 6 Note #98

Merged
merged 3 commits into from
Feb 19, 2024
Merged

Add Chapter 6 Note #98

merged 3 commits into from
Feb 19, 2024

Conversation

BB1464
Copy link
Contributor

@BB1464 BB1464 commented Feb 19, 2024

@jonthegeek please can you please help merge our notes for linear model selection and regularization (Chapter 6) for todays discussion to the main branch. Thank you very much

Copy link
Member

@jonthegeek jonthegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! See comments for a couple things you might want to change.

You can always build the entire collections of notes locally with ctrl-shift-B, or the individual set of slides with ctrl-shift-k. Don't count on changes to necessarily be approved in time to use the online notes. I think we'll PROBABLY make it in time today, but it's always possible that we won't!

.gitignore Show resolved Hide resolved
06_Linear-model-sel-reg.Rmd Outdated Show resolved Hide resolved
@BB1464
Copy link
Contributor Author

BB1464 commented Feb 19, 2024 via email

@jonthegeek
Copy link
Member

Should be good to go, I just need to wait for the other PR to resolve (see #49 about why that might take a while, though).

@jonthegeek
Copy link
Member

This won't be built in time for your club. I recommend trying to build locally if you haven't already. There's an issue in Chapter 8 (caused by a change in one of the packages, I think). I'm going to make it work, but you'll want to make sure it's fixed when you get to that chapter!

Copy link
Member

@jonthegeek jonthegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming it builds now, this is good. Watch out for the autoplots in chapters 8 and 9!

@jonthegeek jonthegeek enabled auto-merge (squash) February 19, 2024 18:40
@jonthegeek jonthegeek merged commit 2d3b160 into r4ds:main Feb 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants