Skip to content

feat(session): implement DisablingStrategy #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
al3mart merged 1 commit into from
Apr 27, 2025
Merged

feat(session): implement DisablingStrategy #538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions runtime/devnet/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,6 +442,7 @@ parameter_types! {
}

impl pallet_session::Config for Runtime {
type DisablingStrategy = ();
type Keys = SessionKeys;
type NextSessionRotation = pallet_session::PeriodicSessions<Period, Offset>;
type RuntimeEvent = RuntimeEvent;
Expand Down
9 changes: 9 additions & 0 deletions runtime/mainnet/src/config/collation.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ impl pallet_collator_selection::Config for Runtime {
impl cumulus_pallet_aura_ext::Config for Runtime {}

impl pallet_session::Config for Runtime {
type DisablingStrategy = ();
type Keys = SessionKeys;
type NextSessionRotation = pallet_session::PeriodicSessions<Period, Offset>;
type RuntimeEvent = RuntimeEvent;
Expand Down Expand Up @@ -255,6 +256,14 @@ mod tests {
mod session {
use super::*;

#[test]
fn ensures_no_disabling_strategy() {
assert_eq!(
TypeId::of::<<Runtime as pallet_session::Config>::DisablingStrategy>(),
TypeId::of::<()>(),
);
}

#[test]
fn keys_provided_by_aura() {
// Session keys implementation uses aura-defined authority identifier type
Expand Down
1 change: 1 addition & 0 deletions runtime/testnet/src/config/collation.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ parameter_types! {
}

impl pallet_session::Config for Runtime {
type DisablingStrategy = ();
type Keys = SessionKeys;
type NextSessionRotation = pallet_session::PeriodicSessions<Period, Offset>;
type RuntimeEvent = RuntimeEvent;
Expand Down
Loading