chore: upgrade to 1.10.0

[chungquantin]

Status: ✅ Tested on my local devnet, testnet => Block production / finalization + submit extrinsic works well.

• ISSUE: chore: upgrade to polkadot 1.14 #141
• Release: https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-v1.10.0
• Prerequisite: chore: upgrade to 1.9.0 #179

References

• Compare pallet-contracts: v1.9.0 and v1.10.0
• Compare pallet-xcm: v1.9.0 and v1.10.0

Direct changes

• [#3696]: Add HRMP notification handlers to the xcm-executor
• [#3844]: Add the ability for MessageQueue to process enqueued messages on idle
• [#3350]: removed pallet::getter from Pallet AURA
• [#3654]: Remove experimental feature from pallet-aura

Export unified ParachainHostFunctions #3854: Exports ParachainHostFunctions to have a bundled version of SubstrateHostFunctions and cumulus_primitives_proof_size_hostfunction::storage_proof_size::HostFunctions. This increases discoverability and makes it more obvious that they should be used together in parachain nodes.

With the introduction of this upgrade, we might need a refactor in the node service.rs to replace the NativeExecutionDispatch implementation with the WasmExecutor<HostFunctions> (See this example). NativeElseWasmExecutor will soon be deprecated in v1.12.0 through the PR 4329

Other updates that might be related

• [#3471]: removed pallet::getter from cumulus pallets
• [#3749]: pallet-xcm: deprecate execute and send in favor of execute_blob and send_blob

pallet-contracts takes the XCM encoded now as well. It follows the same API as execute_blob and send_blob.

• [#3607]: XCM fee payment API

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 28 lines in your changes missing coverage. Please review.

Project coverage is 10.74%. Comparing base (389a2b9) to head (764e41d).

Files	Patch %	Lines
node/src/service.rs	0.00%	24 Missing ⚠️
node/src/command.rs	0.00%	2 Missing ⚠️
runtime/devnet/src/lib.rs	0.00%	1 Missing ⚠️
runtime/testnet/src/lib.rs	0.00%	1 Missing ⚠️

@@              Coverage Diff              @@
##           developer     #182      +/-   ##
=============================================
+ Coverage      10.58%   10.74%   +0.15%     
=============================================
  Files             27       27              
  Lines           2135     2104      -31     
  Branches        2135     2104      -31     
=============================================
  Hits             226      226              
+ Misses          1909     1878      -31     

Files	Coverage Δ
runtime/devnet/src/config/xcm.rs	0.00% <ø> (ø)
runtime/testnet/src/config/xcm.rs	0.00% <ø> (ø)
runtime/devnet/src/lib.rs	14.88% <0.00%> (ø)
runtime/testnet/src/lib.rs	14.88% <0.00%> (ø)
node/src/command.rs	0.00% <0.00%> (ø)
node/src/service.rs	0.00% <0.00%> (ø)

[peterwht]

Really nice!! Great PR description, and the cleanup in the service file is awesome.

Only thing is the removal of the benchmarking host function. Please see comment below.

[peterwht]

[sc-917]

[chungquantin]

Questions: Even though the devnet and testnet can run successfully in this PR with the migration to unified parachain host functions. Do we need to add back the signed extra for POV reclaim feature? Because like we discussed, both runtime should not have this feature enabled.

cc: @al3mart @peterwht

[al3mart]

Indeed @chungquantin, it seems that we will be better leaving those out of the runtimes for now. Some fixes involving POV reclaim have been back-ported upstream, but only to 1.14

• [1.14] Backport PoV-reclaim fixes (#5273, #5281)  paritytech/polkadot-sdk#5371

[chungquantin]

Indeed @chungquantin, it seems that we will be better leaving those out of the runtimes for now. Some fixes involving POV reclaim have been back-ported upstream, but only to 1.14

• [1.14] Backport PoV-reclaim fixes (#5273, #5281)  paritytech/polkadot-sdk#5371

@al3mart I see, thanks for the reference. Hence, this PR is ready for review!

[al3mart]

Looks good!

It would have been great doing a refactor to include a mod for the runtime api impl as in #3817, though it is not strictly necessary for the version bump. 👍 I guess can be tackled in a future change.

Another one that could be handy once we catch up with 1.14 is adding XcmPaymentApi.