Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from rocksdb to simple file for caching vars results #35

Closed
r-zenine opened this issue Dec 25, 2021 · 0 comments · Fixed by #42
Closed

Migrate from rocksdb to simple file for caching vars results #35

r-zenine opened this issue Dec 25, 2021 · 0 comments · Fixed by #42
Assignees
@r-zenine
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
v1.0

Comments

@r-zenine
Copy link
Owner

No description provided.

@r-zenine r-zenine self-assigned this Dec 25, 2021
@r-zenine r-zenine added enhancement New feature or request good first issue Good for newcomers labels Dec 25, 2021
@r-zenine r-zenine added this to the v1.0 milestone Dec 25, 2021
@r-zenine r-zenine moved this to In Progress in sam-1.0 Dec 31, 2021
@r-zenine r-zenine moved this from In Progress to In Review in sam-1.0 Jan 2, 2022
r-zenine added a commit that referenced this issue Jan 3, 2022
@r-zenine
feat(sam-persistence): remove rocksdb dependency for caching and history
97be60f 
rocksdb is swapped for a smaller and simpler library ( rustbreak ) to :

1. Simplify the code and have less edge cases to test.
2. Reduce compilation time on the CI.

In addition, the state management facilities where improved by adding to
abstractions :

1. SequentialState that allows to persistence sequences
2. AssociativeState that allows to persist key-value pairs

This AssociativeState will be reused to deliver #33, #37 and #40

closes #34
closes #35
@r-zenine r-zenine mentioned this issue Jan 3, 2022
Merged
@r-zenine r-zenine moved this from In Review to Done in sam-1.0 Jan 3, 2022
@r-zenine r-zenine moved this from Done to In Review in sam-1.0 Jan 3, 2022
r-zenine added a commit that referenced this issue Jan 3, 2022
@r-zenine
feat(sam-persistence): remove rocksdb dependency for caching and history
c84e9ac 
rocksdb is swapped for a smaller and simpler library ( rustbreak ) to :

1. Simplify the code and have less edge cases to test.
2. Reduce compilation time on the CI.

In addition, the state management facilities where improved by adding to
abstractions :

1. SequentialState that allows to persistence sequences
2. AssociativeState that allows to persist key-value pairs

This AssociativeState will be reused to deliver #33, #37 and #40

closes #34
closes #35
Repository owner moved this from In Review to Approved in sam-1.0 Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@r-zenine r-zenine

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
sam-1.0
Status: Approved
Milestone
v1.0
Development

Successfully merging a pull request may close this issue.

feat(sam-persistence): remove rocksdb dependency for caching and history r-zenine/sam
1 participant
@r-zenine