fix: false positive on sorted_first_last with firstIndex(of:) and las…

…tIndex(of:) method Fixes realm#2700
r-plus · Apr 1, 2019 · c7a1cc1 · c7a1cc1
1 parent 9d0ac2d
commit c7a1cc1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -52,6 +52,11 @@
   [Dalton Claybrook](https://github.com/daltonclaybrook)
   [#2683](https://github.com/realm/SwiftLint/issues/2683)
 
+* Fix false positives on `sorted_first_last` when calling `firstIndex` and
+  `lastIndex` method.
+  [Taiki Komaba](https://github.com/r-plus)
+  [#2700](https://github.com/realm/SwiftLint/issues/2700)
+
 ## 0.31.0: Busy Laundromat
 
 #### Breaking

diff --git a/Source/SwiftLintFramework/Rules/Performance/SortedFirstLastRule.swift b/Source/SwiftLintFramework/Rules/Performance/SortedFirstLastRule.swift
@@ -38,7 +38,7 @@ public struct SortedFirstLastRule: CallPairRule, OptInRule, ConfigurationProvide
 
     public func validate(file: File) -> [StyleViolation] {
         return validate(file: file,
-                        pattern: "[\\}\\)]\\s*\\.(first|last)",
+                        pattern: "[\\}\\)]\\s*\\.(first|last)(?!Index)",
                         patternSyntaxKinds: [.identifier],
                         callNameSuffix: ".sorted",
                         severity: configuration.severity) { dictionary in