Add viridis palette #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Directly in master, can you please do |
Collaborator
Author
|
Added that and deleted the codecov comment. I can also add some tests if that would be useful, I wasn't sure what behavior we'd want to test. |
hadley
approved these changes
Jun 23, 2017
Member
hadley
left a comment
hadley
left a comment
There was a problem hiding this comment.
Can you please add a bullet to NEWS?
-
Generally, I don't worry about updating the version in NEWS, although it's not bad to do so
-
I don't think it's worth a test given how thin a wrapper this is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the viridis palette originally from ggplot2 PR.