Skip to content

Conversation

jimhester
Copy link
Member

Fixes #106

@jimhester jimhester force-pushed the install-git-credentials branch from 5d25c3b to ec665a7 Compare August 28, 2018 20:46
@jimhester jimhester requested a review from gaborcsardi August 28, 2018 20:46
@jimhester jimhester force-pushed the install-git-credentials branch from ec665a7 to ec35fdb Compare August 28, 2018 20:46
@jimhester
Copy link
Member Author

I think the main question with this is the behavior if you try to use credentials with an non git2r backend. Right now it errors in this case.

@codecov-io
Copy link

codecov-io commented Aug 29, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@6fbeeec). Click here to learn what that means.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #146   +/-   ##
=========================================
  Coverage          ?   86.15%           
=========================================
  Files             ?       29           
  Lines             ?     1690           
  Branches          ?        0           
=========================================
  Hits              ?     1456           
  Misses            ?      234           
  Partials          ?        0
Impacted Files Coverage Δ
R/install-git.R 89.77% <88.88%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fbeeec...d7d2657. Read the comment docs.

Copy link
Member

@gaborcsardi gaborcsardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the main question with this is the behavior if you try to use credentials with an non git2r backend. Right now it errors in this case.

I think that's fine.

@jimhester jimhester force-pushed the install-git-credentials branch from e63a55c to d7d2657 Compare August 31, 2018 14:18
@jimhester
Copy link
Member Author

Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants