Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate CNAME during deployment #1240

Merged
merged 10 commits into from
Mar 12, 2020
Merged

Generate CNAME during deployment #1240

merged 10 commits into from
Mar 12, 2020

Conversation

hadley
Copy link
Member

@hadley hadley commented Mar 12, 2020

Fixes #969

@hadley hadley requested a review from jimhester March 12, 2020 15:42
jimhester
jimhester reviewed Mar 12, 2020
View reviewed changes
jimhester
jimhester reviewed Mar 12, 2020
View reviewed changes
jimhester
jimhester approved these changes Mar 12, 2020
View reviewed changes
Copy link
Member

@jimhester jimhester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hadley hadley requested a review from jimhester March 12, 2020 19:10
@hadley hadley merged commit 3123e3b into master Mar 12, 2020
@hadley hadley deleted the deploy-cname branch March 12, 2020 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimhester jimhester Awaiting requested review from jimhester

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CNAME auto-generation can break CDN fronted sites
2 participants
@hadley @jimhester