Assume stringsAsFactors=FALSE

[MichaelChirico]

Another follow-up to #2603

[IndrajeetPatil]

Where relevant, maybe we can also get rid of them from tests?

[MichaelChirico]

Where relevant, maybe we can also get rid of them from tests?

no, all of those are in functions that retained a TRUE default e.g. expand.grid()

[IndrajeetPatil]

Even this one?

    exp <- data.frame(
    filename = rep("dummy.R", 2L),
    line_number = c(1L, 2L),
    column_number = c(1L, 6L),
    type = c("style", "error"),
    message = c("", "Under no circumstances is the use of foobar allowed."),
    line = c("", "a <- 1"),
    linter = c(NA_character_, NA_character_), # These are assigned in lint() now.
    stringsAsFactors = FALSE
  )

[MichaelChirico]

must have missed one :)

[MichaelChirico]

OK, ran an ad hoc linter this time to make sure everything's covered:

l <- make_linter_from_xpath(lint_message = "", "
  //SYMBOL_SUB[text() = 'stringsAsFactors']
    /parent::expr[not(
      expr/SYMBOL_FUNCTION_CALL[text() = 'expand.grid']
      or ./expr/expr/SYMBOL_FUNCTION_CALL[text() = 'table']
    )]
  ")
lint_package(linters = l())

[IndrajeetPatil]

Thanks!