Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.Call() entries might have (void) #290

Merged
merged 2 commits into from
Oct 10, 2022
Merged

.Call() entries might have (void) #290

merged 2 commits into from
Oct 10, 2022

Conversation

romainfrancois
Copy link
Collaborator

since r-devel/r-svn@acd91c3

in response to cran email:

Dear maintainer,

Please see the problems shown on
<https://www.google.com/url?q=https://cran.r-project.org/web/checks/check_results_cpp11.html&source=gmail-imap&ust=1665988745000000&usg=AOvVaw0TUXx2J7KBy_EgFalrLd2O>.

Please correct before 2022-10-24 to safely retain your package on CRAN.

The CRAN Team

@romainfrancois romainfrancois changed the title .Call() entries might have (void) .Call() entries might have (void) Oct 10, 2022
DavisVaughan
DavisVaughan approved these changes Oct 10, 2022
View reviewed changes
tests/testthat/test-register.R
"",
"static const R_CallMethodDef CallEntries[] = {",
call_entries[4:7],
c("static const R_CallMethodDef CallEntries[] = {",
" {\"bar\", (DL_FUNC) &bar, 0},",
" {NULL, NULL, 0}",
"};"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like longer term we are going to be better off switching all of these to snapshot tests, that way we don't break on CRAN if r-devel changes something. We will get notified by our CI instead and can use the variant argument as needed

DavisVaughan
DavisVaughan reviewed Oct 10, 2022
View reviewed changes
Copy link
Member

@DavisVaughan DavisVaughan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh also maybe add a NEWS bullet that links to this PR

@romainfrancois romainfrancois mentioned this pull request Oct 10, 2022
Closed
@romainfrancois romainfrancois merged commit 393a526 into main Oct 10, 2022
@romainfrancois romainfrancois deleted the fix/dot_call_void branch October 10, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavisVaughan DavisVaughan DavisVaughan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romainfrancois @DavisVaughan