set_makevars(): Truly unique variable names and acknowledge comments #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…LAGS and FCFLAGS and would give an error.
jimhester
added a commit
that referenced
this pull request
Jan 11, 2015
set_makevars(): Truly unique variable names and acknowledge comments
|
Thanks! I was aware when I wrote it that I did not protect against matching substrings but I should have been more defensive. I was not aware that FCFLAGS was a common environment variable. |
jimhester
added a commit
that referenced
this pull request
Feb 8, 2024
* increment version * an app with box modules example * boilerplate for box coverage test * ready to write box support * now works with basic box modules * Forgot an s Co-authored-by: Jakub Nowicki <[email protected]> * Smaller version increment as suggested Co-authored-by: Jakub Nowicki <[email protected]> * got it to work! * added support for R6 classes attached as box modules * increment dev version * forgot to update the unit test with R6 modules attached * some refactoring to clean up code * tests for klmr/box attached modules, functions, three dots, and aliases * a little bit of cleanup * code cleanup. finally broke the unlist puzzle * clean up nested (( * test: Fix box cache cleaning in tests. * chore: Add box to suggested dependencies. * chore: Update package version. * added entry in NEWS.md * Trigger CICD * Another CI test trigger pr (#21) * Added `replacements_box()` for `klmr/box` support. * Extracted `traverse_R6()` from `replacements_R6()` to reuse code in `replacements_box()`. * R6 class box modules test cases separated to handle a known R6 issues with `r-devel`. `skip_if(is_r_devel())` is used in the R6 test cases. * Update to covr 3.6.3 (#23) * Adjusted DESCRIPTION and NEWS.md * Different condition to skip tests * Bump version for release --------- Co-authored-by: Jim Hester <[email protected]> * box 1.2.0 released with backports compatibility fixes --------- Co-authored-by: Jakub Nowicki <[email protected]> Co-authored-by: Jakub Nowicki <[email protected]> Co-authored-by: Jim Hester <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A ~/.R/Makevars file
would give:
because string sequence
CFLAGSis part ofFCFLAGS. Moreover, comments were not acknowledged, e.g.would give the same error message.
This pull request addresses both issues.