Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NULL issues #156

Merged
merged 8 commits into from
Mar 23, 2016
Merged

NULL issues #156

merged 8 commits into from
Mar 23, 2016

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Mar 11, 2016

Currently, NULL literals seem to be completely ignored for coverage. A few tweaks to trace_calls() do the trick.

Also addresses errors that occur when coverage result is empty.

Test will have to be amended if #154 is merged.

@jimhester
Copy link
Member

LGTM thanks!

I will wait to merge this until merging #154.

@krlmlr
Copy link
Member Author

krlmlr commented Mar 17, 2016

Merged with master, adapted tests, added NEWS.

@jimhester jimhester merged commit 3ba839d into r-lib:master Mar 23, 2016
@krlmlr krlmlr deleted the feature/null branch March 24, 2016 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants