Add crypto save #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
May 8, 2022 21:55
…lete test suite for the binance app, removes unused code, and runs formatter
…actor + test coverage and crypto trader app live_chart start of test coverage
… saves in binance_pricing crypto_api table (should prolly rename crypto_api as its not being used as an api), and updates pricing as new messages are reiceved through coin fetch/sends ressponse indicated a status of updated or not updated and refactors livechart: app has now been refactored to use the message sent by binance client as an indicator on whether to update the current chart with data from binance_pricing and chart data is now persistent for a current session (user is able to view data since app was started or postgres db has historical data). Notes: breaks prolly all tests 🙃
…ols (to be used later for symbol-display), jerry rigs functionality to allow for any symbol offered by binance.us to be seleceted/live graph be displayed based on db data (currently its configured to start saving upon app start - eventually i want it to save all day/create new record every 24hours for the new day, and prolly still breaks all tests. notes:tests should be easier to write now that app is not relying on messages from binance client - binance client just saves data - sends an updated message - which is used by crypto_trader livechart to determine when to fetch from db
… currency type, refactors crypto_trader to display selection options based on currency - adds hook to trader js to allow for events to be pulled through js/sent through phx to template, and probably destorys the teste suite i wrote 🤙
…refactors js file to be more dry, refactors crypto_trader_web to start binanice.client on application start - allowing for current status to be fetched via calling Binance.client - NOTES: app is currently in a working state, modules need to be renamed before all testing can be added, MVP is nearly completed (prolly need additionaly refactoring)
…d and updated css to allow for more friendly selection display
…ne - APP remians functioning
… app remains functioning
… binance: starts configuring tests, crypto_engine: removes generated tests, and crypto_web: removes failing tests - NOTES: app should now build/pass in CI and all umbrella apps are ready for tests to be built off of new configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.