Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add query again #77

Merged
merged 2 commits into from
Nov 19, 2019
Merged

add query again #77

merged 2 commits into from
Nov 19, 2019

Conversation

maelle
Copy link
Member

@maelle maelle commented Nov 19, 2019

cf #76

You removed the function when removing magrittr, and it's only used in the addin.

It fixes the bug but is maybe not the best way to fix it?

Should tests be added?

@maelle maelle requested a review from gaborcsardi November 19, 2019 09:04
@codecov-io
Copy link

codecov-io commented Nov 19, 2019

Codecov Report

Merging #77 into master will decrease coverage by 0.21%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
- Coverage   34.57%   34.35%   -0.22%     
==========================================
  Files          11       11              
  Lines         943      949       +6     
==========================================
  Hits          326      326              
- Misses        617      623       +6
Impacted Files Coverage Δ
R/utils.R 59.25% <0%> (-7.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84a14d3...2e16544. Read the comment docs.

@gaborcsardi
Copy link
Contributor

I think it is called crandb_query.

@maelle
Copy link
Member Author

maelle commented Nov 19, 2019

Fixed!

@gaborcsardi
Copy link
Contributor

Thanks!

@gaborcsardi gaborcsardi merged commit 8ad32ac into master Nov 19, 2019
@gaborcsardi gaborcsardi deleted the queryagain branch November 19, 2019 09:29
gaborcsardi added a commit that referenced this pull request Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants