nanodbc: more frugal with calls to SQLDescribeParam #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
approved these changes
Jun 11, 2024
We can write an easy test but it will only be effective once we have a pipeline for the PRO drivers. I'll make sure to do that once we have that in place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #814
It seems the SIMBA/Professional MSSQL driver does not faithfully return correct data when invoking
SQLDescribeParammultiple times for the same index.That aside, the commit below should be considered a performance improvement when writing large data sets and with a
batch_sizea fraction of the total number of rows as the API call is called only once for each column ( previously once per-column-per-batch ).