transition odbcDataType() to S4
#756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonpcouch
commented
Jan 30, 2024
| @@ -49,6 +49,7 @@ RoxygenNote: 7.3.0 | |||
| SystemRequirements: GNU make, An ODBC3 driver manager and drivers. | |||
| Collate: | |||
| 'RcppExports.R' | |||
| 'aaa-odbc-data-type.R' | |||
There was a problem hiding this comment.
😞
I wasn't able to find any other places where we needed a workaround to define generics before methods. We could also just delete this file and place its contents in odbc-connection.R?
| #' | ||
| #' `odbcDataType.foo <- function(con, obj, ...) { | ||
| #' switch_type(obj, |
There was a problem hiding this comment.
This example used this unexported switch_type() helper. If we wanted to keep this example, we could export switch_type(), but us never having received an issue related to this makes me wonder if folks ever used this code.
There was a problem hiding this comment.
Yeah, I don't think there's a compelling reason to keep including this example.
hadley
approved these changes
Jan 30, 2024
| #' | ||
| #' `odbcDataType.foo <- function(con, obj, ...) { | ||
| #' switch_type(obj, |
There was a problem hiding this comment.
Yeah, I don't think there's a compelling reason to keep including this example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #701.🐙