Prcandidate/out of order blob #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
col.ctype_ is never mapped to SQL_C_GUID Upstream: 05cccbe0b287635647daf3182a3e9b212486a54c
step To facilitate subsequent data-retrival, route calls to SQLGetData if no buffer is bound to the column. Upstream: b674adc23eb90b142a8045b5ad11440858b31bce
As in nanodbc
…out_of_order_blob
|
Hi Oliver, thanks so much for working on this! Both the upstream patch to nanoodbc and this PR, I apologize for the delay in getting to the review but I think the code looks good as is. As this is a significant contribution I would like to add you as a formal contributor to the package, would you prefer I use your full name or just the |
|
@jimhester thanks again. Appreciate being added as a contributor - full name is fine. |
|
|
This was referenced Oct 16, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @jimhester
This is one approach to tackling the infamous "invalid descriptor" problem. The idea is: If driver is such that out-of-order-retrieval via
SQLGetDatais not possible then unbind allnanodbcbuffers past the first unbound (blob) column.First two patches are a clean-ish backport of the upstream patches that introduce the 'result::unbind' endpoint - but more importantly, route calls to
get<T>toSQLGetDataif there is no bound buffer. Previously this (no buffer bound to the column) was the case only for blobs, but now it's possible for non-blobby columns if the user asked these to be unbound.Second two are
package:odbcpatches that implement the "unbind-if-necessary" logic.connection::get_data_any_orderis particularly ugly - happy to make updates there and elsewhere.Thanks