Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New functionality and fixes by Martin Ficnar #4

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

ficnar
Copy link

@ficnar ficnar commented Jan 3, 2021

Changes:

  • Fix: FsWrapper.ExecuteFileInternal not work for SymLink
  • Add satellite assemblies to installation zip file
  • Support Icon for root folder. Icon automatic extract from main DLL icon (ApplicationIcon), if present.

@ficnar ficnar changed the title fixes: FsWrapper.ExecuteFileInternal not work for SymLink New functionality and fixes by Martin Ficnar Jan 10, 2021
@r-Larch
Copy link
Owner

r-Larch commented Jan 14, 2021

Hi @ficnar,

sorry for my late response, notifications were turned off for this Project.

So, what's the state of this pull-request?

I think your IconExtractor looks good and also the satellite assemblies detection.
Only the SymLink bug needs a different fix, I guess.
I think the problem arises from my paranoid attempt to make all paths of the type RemotePath
and this type is defined to only support absolute paths, so I see the fix in changing the type of
result.SymlinkTarget plus adding the return as you already did correctly.

public struct ExecResult {
    ...
-   internal RemotePath SymlinkTarget;
+   internal string SymlinkTarget;
    ...
}

@ficnar
Copy link
Author

ficnar commented Jan 15, 2021

I think the problem arises from my paranoid attempt to make all paths of the type RemotePath
and this type is defined to only support absolute paths, so I see the fix in changing the type of
result.SymlinkTarget plus adding the return as you already did correctly.

public struct ExecResult {
    ...
-   internal RemotePath SymlinkTarget;
+   internal string SymlinkTarget;
    ...
}

Just for the paranoid attempt, I think my adjustment is better. RemotePath is always an absolute path and ExecResult.ExecutePath should also contain the correct absolute path, not a string where anything can be. Therefore, I would leave ExecResult.ExecutePath as it is and change only the text output to TraceCall, so my original modification:
resStr += " (" + result.SymlinkTarget.Path + ")";

…ject was error during second build (can not copy library).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants