-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New functionality and fixes by Martin Ficnar #4
base: master
Are you sure you want to change the base?
Conversation
Hi @ficnar, sorry for my late response, notifications were turned off for this Project. So, what's the state of this pull-request? I think your IconExtractor looks good and also the satellite assemblies detection. public struct ExecResult {
...
- internal RemotePath SymlinkTarget;
+ internal string SymlinkTarget;
...
} |
Just for the paranoid attempt, I think my adjustment is better. RemotePath is always an absolute path and ExecResult.ExecutePath should also contain the correct absolute path, not a string where anything can be. Therefore, I would leave ExecResult.ExecutePath as it is and change only the text output to TraceCall, so my original modification: |
…ject was error during second build (can not copy library).
Changes: