Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add C# signing example using Bouncy Castle library #880

Merged
merged 1 commit into from
Nov 5, 2021
Merged

Add C# signing example using Bouncy Castle library #880

merged 1 commit into from
Nov 5, 2021

Conversation

psqli
Copy link
Contributor

@psqli psqli commented Oct 21, 2021

No description provided.

@tresf
Copy link
Contributor

tresf commented Oct 30, 2021

@pasqualirb thanks kindly for the code snippet. There's a few areas I'd like changed to closer match our examples. I've made some comments. If not addressed, that's OK, we would supercede them in a separate PR.

@psqli
Copy link
Contributor Author

psqli commented Nov 3, 2021

@pasqualirb thanks kindly for the code snippet. There's a few areas I'd like changed to closer match our examples. I've made some comments. If not addressed, that's OK, we would supercede them in a separate PR.

I'll make the changes and as soon as possible I rebase this PR.

@psqli
Copy link
Contributor Author

psqli commented Nov 5, 2021

I rebased the PR with the requested changes. Please tell me if you find a problem or if you would like any other change.

@tresf tresf merged commit 2d53436 into qzind:master Nov 5, 2021
@tresf
Copy link
Contributor

tresf commented Nov 5, 2021

This looks great, thank you! I think we can eventually fix our examples to cache the private key on each sign request, but that problem already exists in our other .NET examples so that can be tackled at another time. Thanks!!

@psqli psqli deleted the csBouncyCastleSigningExample branch November 5, 2021 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants