Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Developer and "Nightly" editions of Firefox #217

Closed
klabarge opened this issue Aug 1, 2017 · 4 comments · Fixed by #891
Closed

Support for Developer and "Nightly" editions of Firefox #217

klabarge opened this issue Aug 1, 2017 · 4 comments · Fixed by #891
Milestone

Comments

@klabarge
Copy link
Member

klabarge commented Aug 1, 2017

In addition to the stable version of Firefox, there are "Firefox Developer Edition" and "Firefox Nightly" versions: https://www.mozilla.org/en-US/firefox/channel/desktop/

QZ Tray does not work over wss with these versions. Since these versions are not stable, and unlikely to rolled out to production users, is it worth adding support for these versions?

One pro, is that we will be able to fully test QZ Tray + SSL before the features even hit the beta release.

@tresf
Copy link
Contributor

tresf commented Aug 1, 2017

Should be similar to the trick we use for ESR releases, at least on Windows.

https://github.com/qzind/tray/blob/2.0/ant/windows/windows-keygen.js.in#L376

@tresf
Copy link
Contributor

tresf commented Aug 17, 2017

Firefox Developer Edition:

- var firefoxKey = "HKLM\\Software\\Mozilla\\Mozilla Firefox";
+ var firefoxKey = "HKLM\\Software\\Mozilla\\Firefox Developer Edition";

Firefox Nightly:

- var firefoxKey = "HKLM\\Software\\Mozilla\\Mozilla Firefox";
+ var firefoxKey = "HKLM\\Software\\Mozilla\\Nightly";

We'll need to determine how best to shim this into the installer (if at all).

Unlike ESR, Firefox seems to encourage having this installed side-by-side Firefox-stable ,so we may want to install to all versions, which complicates the logic.

@tresf
Copy link
Contributor

tresf commented Dec 12, 2019

Closed via #504.

@tresf tresf closed this as completed Dec 12, 2019
@tresf tresf reopened this Dec 9, 2021
@tresf
Copy link
Contributor

tresf commented Dec 9, 2021

As @sheck points out in #889, it looks like we missed this for MacOS, reopening.

tresf added a commit that referenced this issue Dec 9, 2021
@tresf tresf closed this as completed in #891 Dec 9, 2021
tresf added a commit that referenced this issue Dec 9, 2021
* Add support for experimental Firefox releases
Closes #217, #889
tresf added a commit that referenced this issue Dec 9, 2021
* Add support for experimental Firefox releases
Closes #217, #889
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants