Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: peer deps and async computed #988

Merged
merged 3 commits into from
Oct 12, 2024

Conversation

thejackshelton
Copy link
Collaborator

@thejackshelton thejackshelton commented Oct 11, 2024

What is it?

Sets peer deps to be more variable ranges, so that overrides is not needed, and removes async from computed signals for compatibility with v2

Copy link

changeset-bot bot commented Oct 11, 2024

🦋 Changeset detected

Latest commit: 786da21

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@qwik-ui/headless Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Oct 11, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/qwikifiers/qwik-ui@988
pnpm add https://pkg.pr.new/qwikifiers/qwik-ui/@qwik-ui/headless@988
pnpm add https://pkg.pr.new/qwikifiers/qwik-ui/@qwik-ui/styled@988
pnpm add https://pkg.pr.new/qwikifiers/qwik-ui/@qwik-ui/utils@988

commit: 786da21

@thejackshelton thejackshelton changed the title Quick fixes fix: peer deps and async computed Oct 11, 2024
@maiieul maiieul merged commit e581bf3 into qwikifiers:main Oct 12, 2024
6 checks passed
@github-actions github-actions bot mentioned this pull request Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants