Support for current dev version of qutip #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use packaging version 21.3 to avoid getting no attribute "LegacyVersion" since it was deprecated in newer versions
Use packaging version 21.3 to avoid getting no attribute "LegacyVersion" since it was deprecated in newer versions
machine_image update, trying to fix test jobs
Remove deprecated workflow parameter, adjust labels to contain cirun
Match runners by label
hodgestar
reviewed
Mar 31, 2023
| @@ -1,7 +1,7 @@ | |||
| [build-system] | |||
| requires = [ | |||
| "setuptools>=36.6", | |||
| "packaging", | |||
| "packaging<=21.3", | |||
There was a problem hiding this comment.
We can just replace the code in setup.py as was done in qutip/qutip@2fc35ba8c6 instead of pinning packaging.
hodgestar
reviewed
Mar 31, 2023
| @@ -7,22 +7,20 @@ runners: | |||
| instance_type: g4dn.xlarge # Cheapest VM on AWS | |||
| # Amazon AMI: Deep Learning AMI GPU CUDA 11.2.1 (Ubuntu 20.04) 20210625 | |||
| # for eu-west-1 | |||
| machine_image: ami-07b138161bedd526d | |||
| machine_image: ami-00ac0c28c01352e53 | |||
There was a problem hiding this comment.
Could you find the name and region for the new AMI and update the comment above? Note that we need the AMI for eu-west-1 (I think).
hodgestar
reviewed
Mar 31, 2023
| count: 1 | ||
| labels: | ||
| - gpu | ||
| - "cirun-gpu-runner" |
There was a problem hiding this comment.
Why did the label name change?
hodgestar
reviewed
Mar 31, 2023
| @@ -80,14 +80,14 @@ def is_cupydense(data): | |||
| data.norm.max.add_specialisations([(CuPyDense, cdf.max_cupydense)]) | |||
| data.norm.one.add_specialisations([(CuPyDense, cdf.one_cupydense)]) | |||
|
|
|||
| data.inv.add_specialisations([(CuPyDense, linalg.inv_cupydense)]) | |||
| data.inv.add_specialisations([(CuPyDense, CuPyDense, linalg.inv_cupydense)]) | |||
hodgestar
requested changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in issue #45 there were changes in QuTiPv5 that affected qutip-cupy
Pull requests introduces 2 changes:
Test was conducted on AWS GPU instance and basic check looks good but due to dated packages and qutip-cupy there is possibility for other issues to exist.