Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize keywords: import, using, and export #94

Merged
merged 5 commits into from
May 1, 2024

Conversation

ytdHuang
Copy link
Member

@ytdHuang ytdHuang commented May 1, 2024

close #89

Summary of this PR:

  • Gather all the keyword using (together with @reexport) to the file src/QuantumToolbox.jl for the following packages:
    • LinearAlgebra
    • SparseArrays
    • OrdinaryDiffEq
    • LinearSolve
    • The rest of the dependencies will only use import to avoid messing the in-scope variables and functions
  • Gather all the keyword import to the file src/QuantumToolbox.jl.
  • Separate all the export keyword to individual files where the structures and functions are defined.
  • Remove Distributed from [deps]. Seems that nothing is used from Distributed in the entire package.
  • Change abstract type SteadyStateDirectSolver to empty struct.

Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.31%. Comparing base (6f1948d) to head (6991167).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #94   +/-   ##
=======================================
  Coverage   92.30%   92.31%           
=======================================
  Files          19       19           
  Lines        1742     1743    +1     
=======================================
+ Hits         1608     1609    +1     
  Misses        134      134           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ytdHuang ytdHuang marked this pull request as draft May 1, 2024 10:53
@ytdHuang ytdHuang marked this pull request as ready for review May 1, 2024 11:13
@ytdHuang ytdHuang changed the title Re-organize keywords: import, using, and export Reorganize keywords: import, using, and export May 1, 2024
Copy link
Member

@albertomercurio albertomercurio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@albertomercurio albertomercurio merged commit 0f43c6e into qutip:main May 1, 2024
12 checks passed
@ytdHuang ytdHuang deleted the opt/imports branch May 1, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reorganize the keywords import, using, and export
2 participants