Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local JET runtest #93

Merged
merged 1 commit into from
May 1, 2024
Merged

Fix local JET runtest #93

merged 1 commit into from
May 1, 2024

Conversation

ytdHuang
Copy link
Member

@ytdHuang ytdHuang commented May 1, 2024

For local development, only run code quality tests under VERSION >= v"1.9"
Because JET.test_package does not support for Julia v1.7, and some errors will occur under Julia v1.8.

Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.30%. Comparing base (6f1948d) to head (2dd23a3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #93   +/-   ##
=======================================
  Coverage   92.30%   92.30%           
=======================================
  Files          19       19           
  Lines        1742     1742           
=======================================
  Hits         1608     1608           
  Misses        134      134           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albertomercurio
Copy link
Member

Why does the documentation fail?

@ytdHuang
Copy link
Member Author

ytdHuang commented May 1, 2024

Why does the documentation fail?

The building process somehow breaks at precompilation of the dependencies. I think there are some issues between Plots.jl and GR_jll.

I think the entire Julia community has this problem:

I think we can skip this error first. Someone will do the hotfix for us lol

@albertomercurio
Copy link
Member

Ok, great.

@albertomercurio albertomercurio merged commit 1c1567c into main May 1, 2024
12 checks passed
@ytdHuang ytdHuang deleted the ytdHuang-patch-1 branch May 1, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants