Improve ProgressBar thread safety #212
Merged
+29
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I improved the thread safety of
ProgressBar
. Indeed, theprevious_time
variable was updated in a non-thread-safe way. I converted it into aThreads.Atomic
object and then performed atomic operations on it.Then, I also included a
ReentrantLock
in order to be sure that theprint
functions are thread-safe.Finally, I changed the
ProgressBar
struct to ummutable, improving performances.