Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix benchmarks #117

Merged
merged 1 commit into from
May 22, 2024
Merged

Fix benchmarks #117

merged 1 commit into from
May 22, 2024

Conversation

ytdHuang
Copy link
Member

@ytdHuang ytdHuang commented May 22, 2024

This is a PR to improve the code format suggested in PR #116.

Since the benchmark functions modifies the variable SUITE.
These functions should:

  • take SUITE as an input
  • name as benchmark_XXX!
  • return nothing

Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.04%. Comparing base (9a38e30) to head (60b428b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #117   +/-   ##
=======================================
  Coverage   91.04%   91.04%           
=======================================
  Files          21       21           
  Lines        1754     1754           
=======================================
  Hits         1597     1597           
  Misses        157      157           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albertomercurio albertomercurio merged commit def87cd into qutip:main May 22, 2024
13 checks passed
@ytdHuang ytdHuang deleted the fix/benchmark branch May 28, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants