-
-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
homebrew formula #23
Comments
yep, that would be great, (un)fortunately I don't have a Mac, but I'll tag this issue with |
@gchaincl i am on this one, currently creating formula. |
Homebrew/homebrew-core#12351 waiting to PR to be merged. |
Thanks for doing this @m1ome |
It looks like the PR was rejected due to not having thorough enough post-install tests. Is there something better than |
@gwerbin can you give me more context? What kind of test are they expecting to have? |
I'm not sure what they mean. You did the right thing by asking in that thread. |
@m1ome any progress on this? |
They're looking for some way (other than |
Isn't that enough?
…On Oct 18, 2017 6:00 PM, "Gregory Werbin" ***@***.***> wrote:
They're looking for some way (other than httplab -version to test that
the installation went well.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABOoeUK9T7J_krj1Kg1BSfagZq9NWxULks5stiCFgaJpZM4MajUO>
.
|
Evidently not, but if you can't find a better test that can be encoded in a Ruby script then your best bet is to make a case to the maintainer (the user "ilovezfs") that it's fine as-is. If not, I have an alternative tap (https://github.com/gwerbin/homebrew-tap) for software that I personally use, so I could host it there in the interim. Mind you, I'm not much of a FOSS maintainer myself so I can't guarantee it will always be up-to-date. |
Thanks @gwerbin |
It would be nice to be integrated into homebrew.
The text was updated successfully, but these errors were encountered: