Make events traceable #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new hashmap, eventsIndex, is provided, that allows you to find the event in the timeline if you have eventId. This hashmap uses the fact that deque iterators don't invalidate upon insertion of elements to either end of the deque. Thanks to that, promoteReadMarker() and doAddNewMessageEvents() have been considerably simplified; also, it should be easier now to calculate event indices without rolling back and forth over the timeline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the container for events to
std::deque. This brings in an important guarantee that once inserted, an event object stays in memory where it landed, without relocations upon insertion of further events (somewhat similar tostd::list/QLinkedList); at the same timestd::dequeallows amortized-constant complexity of random access (similar tostd::vector/QVector/QList).Combined with a separate hashmap of event id's to iterators in this deque, it becomes possible to find an arbitrary event object by its id together with its position in the respective timeline. This allows to considerably simplify read marker management: instead of searching back and forth over the timeline, it's now possible to pinpoint an event with a certain id by a single lookup in the hashmap. I suppose, such traceability can bring even more benefits further on.