Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RoomMessageEvent refactoring, take 2 #20

Merged
merged 6 commits into from
Aug 29, 2016
Merged

RoomMessageEvent refactoring, take 2 #20

merged 6 commits into from
Aug 29, 2016

Commits on Aug 24, 2016

  1. Moved message content classes to a dedicated namespace

    @KitsuneRal
    KitsuneRal committed Aug 24, 2016
    Configuration menu
    Copy the full SHA
    958675d View commit details
    Browse the repository at this point in the history

  2. Move plain body from Base (former MessageEventContent) inside RoomMes… 

    …sageEvent

According to the spec, this key has the same status as msgtype: both should exist in any message. Besides, it's always supposed to be a plain text so there's no polymorphism allowed here.
    @KitsuneRal
    KitsuneRal committed Aug 24, 2016
    Configuration menu
    Copy the full SHA
    581a697 View commit details
    Browse the repository at this point in the history

  3. Drop unused (by code and by spec) hsob_ts value

    @KitsuneRal
    KitsuneRal committed Aug 24, 2016
    Configuration menu
    Copy the full SHA
    51dfcc7 View commit details
    Browse the repository at this point in the history

  4. Introduce TextContent + minor cleanup 

    TextContent is a class to deal with formatted (HTML, RTF, Markdown) text messages. Right now it only supports Vector's non-standard "formatted_body".
    @KitsuneRal
    KitsuneRal committed Aug 24, 2016
    Configuration menu
    Copy the full SHA
    596533a View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2016

  1. Structured parsing, folded repetitive initialization code

    @KitsuneRal
    KitsuneRal committed Aug 25, 2016
    Configuration menu
    Copy the full SHA
    6a28821 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2016

  1. Align AudioContent with the rest; special-case creation of VideoConte… 

    …nt only

The spec is told to allow any event to have a thumbnail in future, and the thumbnail will reside under "content" JSON key rather than "info".
    @KitsuneRal
    KitsuneRal committed Aug 29, 2016
    Configuration menu
    Copy the full SHA
    32ff7cd View commit details
    Browse the repository at this point in the history