Some QJson* wrappers #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KitsuneRal
force-pushed
the
kitsune-json
branch
from
4f8edd0
to
606acee
Compare
KitsuneRal
force-pushed
the
kitsune-master
branch
from
b1afdf5
to
c768cbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to get a peer review for the things below (it's better to look at the whole PR rather than commits separately). Basically, I feel that the current code is a bit too long to write without adding clarity or safety, so I felt separating the boilerplate parts into wrappers.
json.cppis there (so far) purely to please Qt Creator that doesn't tackle header-only things well. Together with the wrappers I've made a couple of proof-of-concepts in PasswordLoginJob and SyncJob so that it were clearer what I'm aiming at. The PR targets kitsune-master now, and might eventually land in master, as well.