Fetch previous messages in a more intelligent way #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w much to fetch * getPreviousContent() won't be triggered during the model resetting; this should prevent unnecessary fetching reported in quotient-im#118. * Previously we used a hard 5-pixel margin to check if it's time to scroll and fetched strictly 10 messages. This led to stuttering when scrolling far back the timeline, as reported in quotient-im#94. The new code calculates whether there are enough pixels above to scroll at the same speed for the nearest 2 seconds, and if not, fetches additional messages that would amount to about 3 additional seconds of scrolling (assuming that an average height of a fetched message in pixels will be the same as the average message height for the already loaded timeline). Closes quotient-im#94, quotient-im#118
|
❌ Build Quaternion 0.0.195 failed (commit 2f1289ddea by @KitsuneRal) |
|
✅ Build Quaternion 0.0.196 completed (commit e44059ebfb by @KitsuneRal) |
|
✅ Build Quaternion 0.0.198 completed (commit 2f46870d0b by @KitsuneRal) |
nicolasfella
pushed a commit
to nicolasfella/Quaternion
that referenced
this pull request
Dec 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit message says it all. Closes #94, #118
Deadline for reviews - 7 days (by Mar-16).