Skip to content

Commit

Permalink
Test: update grunt-contrib-qunit to puppeteer 21.3
Browse files Browse the repository at this point in the history
Fixed offset bug upstream.

Ref puppeteer/puppeteer#10921
Ref puppeteer/puppeteer#10926
  • Loading branch information
Krinkle committed Sep 23, 2023
1 parent cb67c39 commit 61e1a3f
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
3 changes: 1 addition & 2 deletions test/integration/grunt-contrib-qunit.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,9 @@ QUnit.test.each('failing tests', {
>> Expected: undefined
>> Error: No tests were run.
>> at `],
// FIXME: Error line is off by one in Chrome, broke betweeen Puppeteer 9 and 21.
uncaught: ['fail-uncaught', `Testing fail-uncaught.html \n\
>> ReferenceError: boom is not defined
>> at file:fail-uncaught.html:15`]
>> at file:fail-uncaught.html:16`]
}, (assert, [command, expected]) => {
try {
const ret = cp.execSync('node_modules/.bin/grunt qunit:' + command, {
Expand Down
5 changes: 3 additions & 2 deletions test/integration/grunt-contrib-qunit/package.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
{
"private": true,
"devDependencies": {
"grunt": "^1.6.1",
"grunt-contrib-qunit": "^8.0.1"
"grunt": "1.6.1",
"grunt-contrib-qunit": "8.0.1",
"puppeteer": "21.3.4"
},
"scripts": {
"test": "grunt"
Expand Down

0 comments on commit 61e1a3f

Please sign in to comment.