Add support for spreads in object literals #98
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In values, this syntax isn't legal until ECMAScript 9; but in object destructuring binding patterns, this is an ES 6 feature. The implementation for both ends up being the same, so this commit tests both.
erikd
approved these changes
Sep 5, 2019
|
This is embarrassing, but it seems that I was just point-blank wrong in my commentary—this entire feature isn't legal until ES 9. I could have sworn I checked the ES 6 spec for it, but I must have gotten confused. Retracting accordingly. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In values, this syntax isn't legal until ECMAScript 9; but in object
destructuring binding patterns, this is an ES 6 feature. The
implementation for both ends up being the same, so this commit tests
both.