Skip to content

Add support for function declarations export statements #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erikd merged 1 commit into from
Jun 16, 2019
Merged

Add support for function declarations export statements #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/Language/JavaScript/Parser/Grammar7.y
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1261,6 +1261,15 @@ ImportSpecifier : IdentifierName
-- [x] export ExportClause ;
-- [x] export VariableStatement
-- [ ] export Declaration
-- [ ] Declaration :
-- [ ] HoistableDeclaration
-- [ ] ClassDeclaration
-- [x] LexicalDeclaration
-- [ ] HoistableDeclaration :
-- [x] FunctionDeclaration
-- [ ] GeneratorDeclaration
-- [ ] AsyncFunctionDeclaration
-- [ ] AsyncGeneratorDeclaration
-- [ ] export default HoistableDeclaration[Default]
-- [ ] export default ClassDeclaration[Default]
-- [ ] export default [lookahead ∉ { function, class }] AssignmentExpression[In] ;
Expand All @@ -1269,6 +1278,8 @@ ExportDeclaration : ExportClause AutoSemi
{ $1 {- 'ExportDeclaration1' -} }
| VariableStatement AutoSemi
{ AST.JSExport $1 $2 {- 'ExportDeclaration2' -} }
| FunctionDeclaration AutoSemi
{ AST.JSExport $1 $2 {- 'ExportDeclaration2' -} }

-- ExportClause :
-- { }
Expand Down
3 changes: 3 additions & 0 deletions test/Test/Language/Javascript/ModuleParser.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@ testModuleParser = describe "Parse modules:" $ do
test "export const a = 1;"
`shouldBe`
"Right (JSAstModule [JSModuleExportDeclaration (JSExport (JSConstant (JSVarInitExpression (JSIdentifier 'a') [JSDecimal '1'])))])"
test "export function f() {};"
`shouldBe`
"Right (JSAstModule [JSModuleExportDeclaration (JSExport (JSFunction 'f' () (JSBlock [])))])"
test "export { a };"
`shouldBe`
"Right (JSAstModule [JSModuleExportDeclaration (JSExportLocals ((JSExportLocalSpecifier (JSIdentifier 'a'))))])"
Expand Down